fablo icon indicating copy to clipboard operation
fablo copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger-labs

confirmation prompt for down, prune and recreate commands

Open Sanket-0510 opened this issue 10 months ago • 5 comments

fixes: #324 I have added the confirmation prompt for critical commands like down, prune recreate also added the --silent flag which will bypass this prompt.

Sanket-0510 avatar Apr 09 '24 19:04 Sanket-0510

I think I pushed the wrong branch, but I have corrected it.

Sanket-0510 avatar Apr 09 '24 19:04 Sanket-0510

@dzikowski do checkout these commands

Sanket-0510 avatar Apr 26 '24 21:04 Sanket-0510

It looks legit. Could you also fix tests? It includes e2e-network tests and snapshots probably.

dzikowski avatar May 07 '24 13:05 dzikowski

yeah I have ran this command npm run test:e2e-update to update snapshots but nothing changed.

Sanket-0510 avatar May 07 '24 13:05 Sanket-0510

It fails on e2e-network/docker/test-01-simple.sh script. You can execute it locally and check. I guess this is missing --silent flag in the sh test file.

dzikowski avatar May 07 '24 14:05 dzikowski