fablo icon indicating copy to clipboard operation
fablo copied to clipboard

Refactor to improve lines of code script

Open afzal442 opened this issue 1 year ago • 3 comments

Used cat instead of echo to write multi-line text, and used a here-document (<<EOF) to make the code more readable. Used read -r to avoid issues with backslashes in container names. Added TypeScript type annotations for the function parameters and return types.

cc @dzikowski

afzal442 avatar May 17 '23 16:05 afzal442

hi @dzikowski can you review this? thanks

afzal442 avatar May 27 '23 06:05 afzal442

sure @afzal442 and thanks for contribution. Everything is fine, it just needs to wait a bit till fix CI processes.

dzikowski avatar May 29 '23 08:05 dzikowski

Thanks @dzikowski for that. I tried to reach out to you. Did you get to review my proposal for this project?

afzal442 avatar May 29 '23 15:05 afzal442