convector icon indicating copy to clipboard operation
convector copied to clipboard

Empty object should be handled before passing to JSON.parse

Open Vishwas1 opened this issue 5 years ago • 1 comments

The problem

in this line empty object should be handled before passing to JSON.parse... check it out const result = JSON.parse(txResult.result.response.payload.toString('utf8'));

https://github.com/hyperledger-labs/convector/blob/develop/%40worldsibu/convector-common-fabric-helper/src/client.helper.ts#L198

Environment

  • Convector version (or git revision) that exhibits the issue:
  • Last Convector version that did not exhibit the issue (if applicable):
  • OS/version:
  • Node.js version:
  • Npm or Yarn package manager:
  • Convector CLI version (if applicable):
  • Hurley CLI version (if applicable):

Details

Current Behavior

Explain what the current behavior is

Expected Behavior

Explain what you were expecting to happend instead

Code To Reproduce Issue [ Good To Have ]

Please remember that with sample code it's easier to reproduce the bug and it's much faster to fix it.

Use convector-cli if possible as the base to reproduce the issue

Vishwas1 avatar Apr 12 '19 20:04 Vishwas1

Hey @Vishwas1, thanks for the issue. Can you please provide an example of how to reproduce your issue? Or explain a little bit more in detail what the problem is? Thanks

diestrin avatar May 30 '19 19:05 diestrin