indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard

Update indy-walkthrough.md

Open meadoch1 opened this issue 3 years ago • 5 comments

This work changes "Trust Anchor" to "Endorser" to align with the changes in 79aed586c586da8d47adb423ff3f7dcbf31fcb22

meadoch1 avatar Jan 14 '22 13:01 meadoch1

The SHA referenced is in indy-node. https://github.com/hyperledger/indy-node/commit/79aed586c586da8d47adb423ff3f7dcbf31fcb22#diff-2088d14bfcb85060b0b7a97ab31573a39e6fcfba76804d1c27194fc6cea46379

meadoch1 avatar Jan 14 '22 13:01 meadoch1

Thanks @meadoch1. Could you add the required DCO sign-off to your commit please. Details here; https://github.com/hyperledger/indy-sdk/pull/2462/checks?check_run_id=4817377128

WadeBarnes avatar Jan 14 '22 14:01 WadeBarnes

Done. Sorry for the misstep. I did the work via Github's editor and didn't think about a doc update triggering other checks. Will be more mindful in the future.

meadoch1 avatar Jan 14 '22 17:01 meadoch1

Thanks

WadeBarnes avatar Jan 14 '22 17:01 WadeBarnes

@meadoch1, I've fixed the issues causing the Jenkins builds to fail (https://github.com/hyperledger/indy-sdk/pull/2470). If you rebase your PR on the latest from the main branch the builds should work and we can get your PR merged. I know this is just a documentation update, but the builds passing is a gate to allow the PR to be merged.

WadeBarnes avatar Jan 21 '22 16:01 WadeBarnes