indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard

Add a podspec for objective-c indy wrapper in non-binary distribution

Open conanoc opened this issue 4 years ago • 4 comments

Signed-off-by: conanoc [email protected]

Previous podspec libindy-objc.podspec has several issues:

  • It is based on pre-built binary and the binaries are not provided since v1.8.2
  • Old binaries do not support newer versions of swift
  • Binary frameworks cannot support multiple versions of swift

Source based podspec would be more convenient because we do not have to prepare binaries and there is no version dependency for swift. Some notes about this commit:

  • The podspec filename have to be the same as the name of the framework. So, I could not keep the previous name libindy-objc.podspec.
  • The lastest version of libindy is v1.16.0, but one source file of the wrapper(wrappers/ios/libindy-pod/Indy/Wrapper/IndyErrors.h) had a bug(comma missing) and was fixed later. So, tag v1.16.0 cannot be used for ios wrapper.
  • Used OpenSSL-XM(1.0.210.1) pod instead of OpenSSL(1.0.210) pod because OpenSSL is not compatible with the latest version of cocoapods. OpenSSL podspec would be better copied to indy-sdk repo with fixes done in OpenSSL-XM.

conanoc avatar Nov 10 '21 08:11 conanoc

A fix for the build issues has been implemented (https://github.com/hyperledger/indy-sdk/pull/2470). Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.

WadeBarnes avatar Jan 21 '22 16:01 WadeBarnes

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

conanoc avatar Jan 26 '22 06:01 conanoc

@WadeBarnes After the rebase, build-image-wrapper-base is failing. Any idea?

@conanoc, I missed updating the Rust version in a spot; https://github.com/hyperledger/indy-sdk/pull/2475. You won't need to rebase again since the GHA workflows do not block the ability to merge.

WadeBarnes avatar Jan 31 '22 14:01 WadeBarnes

@mirgee, Is this something you could review?

WadeBarnes avatar Feb 01 '22 15:02 WadeBarnes