indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard

docs: Update getting started dockerfile

Open rach-id opened this issue 3 years ago • 9 comments

Ubuntu 16.04 still installs Python:2.7 and pip. Thus, the getting-started docker image doesn't build as expected. So, an update to Ubuntu:20.04 is needed for the images to build successfully.

rach-id avatar Oct 30 '21 18:10 rach-id

This fixes build error, how can we get someone to look at this?

dlz21 avatar Jan 10 '22 01:01 dlz21

If someone is interested in merging this, I can fix the pipelines :D

rach-id avatar Jan 10 '22 10:01 rach-id

@SweeXordious, You need to add DCO sign-off to your commits. Details here; https://github.com/hyperledger/indy-sdk/pull/2438/checks?check_run_id=4056269767

WadeBarnes avatar Jan 10 '22 12:01 WadeBarnes

@WadeBarnes Can you please let me know why the CI is not passing ? I don't have access to jenkins

rach-id avatar Jan 10 '22 14:01 rach-id

@WadeBarnes Can you please let me know why the CI is not passing ? I don't have access to jenkins

It's a rust (cargo) version issue that is failing the builds. https://github.com/hyperledger/indy-sdk/pull/2452#issuecomment-988177968

More specifically; https://github.com/hyperledger/indy-sdk/issues/2460

WadeBarnes avatar Jan 10 '22 16:01 WadeBarnes

Thanks, will wait until it's fixed then rebase

rach-id avatar Jan 10 '22 17:01 rach-id

A fix for the build issues has been implemented (https://github.com/hyperledger/indy-sdk/pull/2470). Please rebase this PR on the latest from the main branch so it is no longer blocked by the related build issues.

WadeBarnes avatar Jan 21 '22 16:01 WadeBarnes

@SweeXordious, Sorry, it looks like the merge from another PR has created a conflict with your change. Could you please review.

WadeBarnes avatar Jan 24 '22 17:01 WadeBarnes

@WadeBarnes Thanks for letting me know. Conflicts resolved.

rach-id avatar Jan 24 '22 18:01 rach-id