indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard

fix ordering of attributes being used before being introduced

Open AxelNennker opened this issue 4 years ago • 2 comments

Signed-off-by: Axel Nennker [email protected]

The compiler was complaining about the following:

warning: derive helper attribute is used before it is introduced --> src/services/pool/types.rs:357:3 | 357 | #[serde(tag = "op")] | ^^^^^ 358 | #[derive(Serialize, Deserialize, Debug)] | --------- the attribute is introduced here | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79202 https://github.com/rust-lang/rust/issues/79202

This PR reorders the two code lines so that the attribute is used after being introduced

AxelNennker avatar Oct 07 '21 14:10 AxelNennker

I think the build failure is not due to this PR.

AxelNennker avatar Oct 08 '21 06:10 AxelNennker

@AxelNennker, you are correct, it is not. A fix for the build issues has been implemented (#2470), which should have also addressed the changes you made here. Please confirm and close the PR is this is the case.

WadeBarnes avatar Jan 21 '22 16:01 WadeBarnes