indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard
verified publisher icon hyperledger-archives

Update VCX Nodejs wrapper node version to 12

Open mirgee opened this issue 5 years ago • 3 comments

This PR is based on #2021. Bacause of this issue, the openssl library has be linked statically. Achieved via vendored feature.

mirgee avatar May 19 '20 12:05 mirgee

@mirgee as far as I remember there were 2 blockers to migrate from 8 to 12 NodeJS

  1. openssl system library - it should be already fixed in master by linking to the correct version of openssl and the migration were done partially (to v10)
  2. ffi-napi issue was last blocker to do a migration from 10 to 12.

Let me check the status of #2021

Usage of vendored feature may increase CI/CD time

jovfer avatar May 19 '20 13:05 jovfer

@jovfer

openssl system library - it should be already fixed in master by linking to the correct version of openssl and the migration were done partially (to v10)

I was still experiencing the openssl issue with node 12 + ffi-napi (and node 10 on master), that's why I added the vendored feature, which fixed it...

Usage of vendored feature may increase CI/CD time

How much would it slow the CI time? On my computer, libvcx build is ~7 s slower with vendored feature.

mirgee avatar May 19 '20 16:05 mirgee

Hey @jovfer and @mirgee, what is the current state of this pr? I would like to know when it will be merged.

solidnerd avatar Oct 22 '20 03:10 solidnerd