indy-sdk icon indicating copy to clipboard operation
indy-sdk copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger-archives

Add VCX Java demo

Open baegjae opened this issue 4 years ago • 7 comments

This VCX Java Alice/Faber demo was created with reference to the VCX node demo.

Also, it contains small bug fix in VCX Java wrapper APIs.

  • issuerSendCredentialCB - Remove credentialDefId parameter (incurred error)
  • vcxProofGetStateCB - Remove proofHandle parameter (returned wrong state)

baegjae avatar Apr 24 '20 04:04 baegjae

Looks good to me 👍 Let's wait for @jovfer 's review as well.

Patrik-Stas avatar May 22 '20 15:05 Patrik-Stas

@Patrik-Stas @mirgee, only 1 nuance makes me concerned about this PR: it puts jar binary to the repo. If there is no reasonable way to avoid it - fill free to merge it. Everything else is a valuable contribution for sure, thank you @baegjae

jovfer avatar Jun 10 '20 19:06 jovfer

@jovfer Currently, demo is not executed when using maven's com.evernym:vcx:0.8.0, so it is written to use the local vcx java wrapper (jar) temporarily. In my opinion, it would be better to merge this PR first. Next, as soon as this PR's bugfix applies to maven, I will register a PR that imports the vcx java wrapper from maven.

baegjae avatar Jun 11 '20 01:06 baegjae

@baegjae I see it's common practice to commit gradlew files cvs, and the .jar file is just 50kb, but for sake of security, can you make binary file checksum as part of jenkins pipeline? See: https://docs.gradle.org/current/userguide/gradle_wrapper.html#wrapper_checksum_verification

Patrik-Stas avatar Jul 08 '20 07:07 Patrik-Stas

@Patrik-Stas I applied the your request. If you have any further needs, please let me know.

baegjae avatar Jul 09 '20 08:07 baegjae

@baegjae Thanks for update - however still missing the check part. I'd rather not have the checksum file as part of the repo - instead either in jenkins, or as a github action, I'd like to:

  • download the checksum file for this gradlew version from gradle.org
  • verify the checksum as part of the pipeline

I think actually this will be much easier to add as github action. Extending existing Jenkins pipeline can be quite difficult due to extremely long feedback loop.

Patrik-Stas avatar Jul 13 '20 06:07 Patrik-Stas

Since VCX is forked and will be removed here, I think this PR should be dropped in this repository. https://github.com/hyperledger/indy-sdk/pull/2416

kukgini avatar May 13 '22 23:05 kukgini