indy-sdk-react-native icon indicating copy to clipboard operation
indy-sdk-react-native copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger-archives

iOS and Android native modules have different method signatures

Open jakubkoci opened this issue 4 years ago • 0 comments
trafficstars

This has been copied from https://github.com/AbsaOSS/rn-indy-sdk/issues/25

@TimoGlastra wrote: See the code samples below. for example proverCreateCredentialReq for iOS and Android sides expect different order of parameters. I guess because they match the native indy library for iOS/Android.

However I think we should abstract that away on the native side and make the call from the JS side the same for both.

https://github.com/AbsaOSS/rn-indy-sdk/blob/43aff51c158cb871c12ce4247aa7df74690e51da/android/src/main/java/com/reactlibrary/IndySdkModule.java#L507

https://github.com/AbsaOSS/rn-indy-sdk/blob/43aff51c158cb871c12ce4247aa7df74690e51da/ios/IndySdk.swift#L302-L304

jakubkoci avatar Jul 19 '21 13:07 jakubkoci