fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Membership Services refactoring: separate and break down the code to more files

Open JonathanLevi opened this issue 8 years ago • 2 comments

Description

While the good ol' Membership Services CA package implementation has some logical separation to sub-modules/structs, we can break down the implementation to separate files (e.g., move Google's Protocol Buffers language-neutral data serialization/API to separate/dedicated files, refactor TCAA and TCAP out of tca.go, ECAA and ECAP from eca.go and ACAP from aca.go)

Describe How to Reproduce

N/A. Code restructuring, not a bug.

JonathanLevi avatar Jun 27 '16 22:06 JonathanLevi

+1 suggest the refactor be gradual as possible and that unit tests are added where appropriate.

christo4ferris avatar Jun 27 '16 22:06 christo4ferris

OK, thanks. Will break it down to separate PRs too, as suggested. Will begin with the easy/straight forward ones (protobuf & co.)

JonathanLevi avatar Jun 27 '16 23:06 JonathanLevi