fabric icon indicating copy to clipboard operation
fabric copied to clipboard

asset management test case should be moved out of examples/... path

Open muralisrini opened this issue 8 years ago • 4 comments

asset management test case will not be run as part of the running unit test case per doc directions if its under examples/... folder. It should be moved to chaincode/ folder.

muralisrini avatar Apr 09 '16 16:04 muralisrini

I think it should stay with the asset management chaincode. I'll try to figure out how to make the UTXO chaincode test case not break. That's the only reason we have the documentation to exclude the examples/ folder.

srderson avatar Apr 09 '16 19:04 srderson

The entire .../asset_management/* is a test for ACL with chaincode and is standalone. Why would we not run it as part of unit tests ?

muralisrini avatar Apr 09 '16 19:04 muralisrini

I think I misunderstood @srderson comment... if we can arrange it so we don't exclude examples/ from unit tests, then, the asset_management test case (rightly) belongs where it is.

muralisrini avatar Apr 09 '16 19:04 muralisrini

personally, I think that 'examples' is an awful name for chaincode that we use for tests. We should have a test/artifacts tree for that and examples should be exemplar code that is well documented and exhibits best practices. Sometimes, such as with chaincode that exhibits nondeterminism for purposes of ensuring that such chaincode is flagged, etc we will have bad practices and we don't want users emulating this sort of code.

christo4ferris avatar Jul 25 '16 14:07 christo4ferris