aries-framework-go
aries-framework-go copied to clipboard
fix: Docker warning when using frapsoft/openssl on arm64 system
Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does work fine on arm64 macOS currently as it seems that Docker makes use of QEMU to support emulation of non-native architectures).
Signed-off-by: Derek Trider [email protected]
Codecov Report
Merging #3374 (7ccc688) into main (368f53b) will decrease coverage by
0.00%
. The diff coverage is86.66%
.
@@ Coverage Diff @@
## main #3374 +/- ##
==========================================
- Coverage 87.57% 87.56% -0.01%
==========================================
Files 343 343
Lines 46809 46832 +23
==========================================
+ Hits 40994 41010 +16
- Misses 4318 4323 +5
- Partials 1497 1499 +2
Impacted Files | Coverage Δ | |
---|---|---|
...to/primitive/aead/aes_cbc_hmac_aead_key_manager.go | 90.74% <ø> (ø) |
|
...tinkcrypto/primitive/bbs/bbs_signer_key_manager.go | 83.46% <ø> (ø) |
|
...nkcrypto/primitive/bbs/bbs_verifier_key_manager.go | 100.00% <ø> (ø) |
|
...composite/ecdh/ecdh_nistpkw_private_key_manager.go | 90.07% <ø> (ø) |
|
.../composite/ecdh/ecdh_nistpkw_public_key_manager.go | 88.88% <ø> (ø) |
|
...omposite/ecdh/ecdh_x25519kw_private_key_manager.go | 82.94% <ø> (ø) |
|
...composite/ecdh/ecdh_x25519kw_public_key_manager.go | 88.88% <ø> (ø) |
|
...imitive/composite/register_ecdh_aead_enc_helper.go | 87.94% <ø> (ø) |
|
...rimitive/secp256k1/secp256k1_signer_key_manager.go | 82.90% <ø> (-2.57%) |
:arrow_down: |
...mitive/secp256k1/secp256k1_verifier_key_manager.go | 65.71% <ø> (ø) |
|
... and 8 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@rolsonquadras Can you merge? The unit test failure appears to be some intermittent failure happening in AFGo.