aries-framework-go icon indicating copy to clipboard operation
aries-framework-go copied to clipboard

chore: switch square/go-jose to go-jose/go-jose part 1

Open baha-ai opened this issue 3 years ago • 1 comments

This change switches go-jose project from square to the new go-jose repo. It also removes the Ed25519 JWK thumbprint bug fix from the framework since it is now fixed in the new repo of the go-jose project.

A followup change will be added to fully remove square/go-jose repository references.

Signed-off-by: Baha Shaaban [email protected]

baha-ai avatar Jan 12 '22 14:01 baha-ai

Codecov Report

Merging #3122 (565a114) into main (cdf6a4b) will decrease coverage by 0.04%. The diff coverage is 50.00%.

:exclamation: Current head 565a114 differs from pull request most recent head c99b239. Consider uploading reports for the commit c99b239 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
- Coverage   88.81%   88.76%   -0.05%     
==========================================
  Files         307      307              
  Lines       41367    41027     -340     
==========================================
- Hits        36739    36418     -321     
+ Misses       3369     3360       -9     
+ Partials     1259     1249      -10     
Impacted Files Coverage Δ
pkg/crypto/tinkcrypto/key_wrapper.go 82.89% <ø> (ø)
...rypto/primitive/aead/subtle/gojose_aes_cbc_hmac.go 72.72% <ø> (ø)
pkg/crypto/tinkcrypto/wrap_support.go 93.19% <ø> (ø)
pkg/didcomm/protocol/didexchange/keys.go 85.29% <ø> (ø)
pkg/didcomm/protocol/outofbandv2/service.go 71.91% <ø> (-2.61%) :arrow_down:
pkg/doc/jose/encrypter.go 86.55% <ø> (ø)
pkg/doc/jose/jwe.go 100.00% <ø> (ø)
pkg/doc/jose/jwk/jwk.go 86.77% <ø> (ø)
pkg/doc/jose/jwk/jwksupport/jwk.go 92.85% <ø> (ø)
pkg/doc/jose/jws.go 94.11% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdf6a4b...c99b239. Read the comment docs.

codecov[bot] avatar Jan 12 '22 15:01 codecov[bot]