aries-framework-go icon indicating copy to clipboard operation
aries-framework-go copied to clipboard

VC wallet : enable proof check for VCs while adding, proving

Open sudeshrshetty opened this issue 3 years ago • 1 comments

Currently we have disabled proof check in verifiable command & vcwallet client while saving, proving (creating presentation).

There isn't any concrete reason why we should or shouldn't verify credentials while saving or while generating presentation.

If we enable proof check: Cons : May impact performance a little (resolving DID, keys, verification etc) Pros : We can show credentials 'verified, unverified' etc in wallet to user. Like shown in below sample below. image

Another option: we can make this option configurable in VC wallet profile where user can change preference at his or her will. By default - disabled.

sudeshrshetty avatar Mar 25 '21 15:03 sudeshrshetty

My suggestion: we can disable proof check while saving/presenting credentials because we have dedicated interface in universal wallet called verify, wallet UI can call that function whenever it wants to verify a VC it is showing to user in wallet.

sudeshrshetty avatar Mar 25 '21 15:03 sudeshrshetty