aries-framework-dotnet icon indicating copy to clipboard operation
aries-framework-dotnet copied to clipboard

Mediator Metadata

Open Alexis-Falquier opened this issue 4 years ago • 5 comments

It seems like the mediator was intended to be able to hold metadata about a registered inbox as there is an optional parameter "metadata" on the function "CreateInboxAsync" (code here) but where this function is called on the edge functionality it does not give the option to pass in metadata (code here) On the mediator side of things we looked at the function that handles this (code here) and found that even if the metadata was passed it does nothing with it.

did we by chance miss something and there is still a way to set and get metadata for an inbox in the mediator? Or was this functionality abandoned?

Alexis-Falquier avatar Jan 27 '21 19:01 Alexis-Falquier

Yeah, this sounds like it was intended, but never actually used. Sounds like we just need to make small changes to make this work.

tmarkovski avatar Jan 27 '21 21:01 tmarkovski

So we are going to need this functionality and will be happy to make these changes and make a PR do you happen to know what specifically needs to be changed? Seems like the scope of these changes should be fairly minimal correct?

Alexis-Falquier avatar Jan 27 '21 21:01 Alexis-Falquier

Hi @tmarkovski, we prepared a fix for this with unit tests. Please review this #164

Any comments more then welcome.

MaticDiba avatar Feb 04 '21 15:02 MaticDiba

Thank, merged. If you need this released, can you submit a PR with the version bumped at https://github.com/hyperledger/aries-framework-dotnet/blob/e475b20cfba5b0be11e614e66d8633d5bd21ca98/Directory.Build.props#L12, so we can publish it to nuget?

tmarkovski avatar Feb 04 '21 16:02 tmarkovski

Thank you. We will prepare another one. Will add version bump to that one.

MaticDiba avatar Feb 05 '21 07:02 MaticDiba