hyperlane-monorepo icon indicating copy to clipboard operation
hyperlane-monorepo copied to clipboard

fix(contracts): quote management for L2->L1 hooks

Open aroralanuk opened this issue 1 year ago • 3 comments

Description

  • check for sufficient fees in AbstractMessageIdAuthHook and refund surplus
  • add a child hook to OPL2ToL1Hook and ArbL2ToL1Hook to use the igp to pay for the destination gas fees

Note: LayerzeroL2Hook currently also refunds from msg.value, will make it into issue to be fixed later as we're using the layerzero hooks right now.

Drive-by changes

  • None

Related issues

  • fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/10

Backward compatibility

No

Testing

Fuzz

aroralanuk avatar Sep 23 '24 10:09 aroralanuk

🦋 Changeset detected

Latest commit: 255f59873b54290727c6b5dbbbfa73bd4d57ef2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 23 '24 10:09 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.20%. Comparing base (56328e6) to head (5edc95a). Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4552      +/-   ##
==========================================
+ Coverage   73.97%   74.20%   +0.22%     
==========================================
  Files         101      101              
  Lines        1460     1473      +13     
  Branches      191      191              
==========================================
+ Hits         1080     1093      +13     
  Misses        359      359              
  Partials       21       21              
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.13% <88.00%> (+1.41%) :arrow_up:
isms 77.58% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.39% <ø> (ø)

codecov[bot] avatar Sep 23 '24 10:09 codecov[bot]

⚠️ The sha of the head commit of this PR conflicts with #4541. Mergify cannot evaluate rules on this PR. ⚠️

mergify[bot] avatar Sep 25 '24 09:09 mergify[bot]