monika icon indicating copy to clipboard operation
monika copied to clipboard

Remove axios package

Open irwansyahwii opened this issue 1 year ago • 3 comments

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Remove Axios and replace it with native fetch

How did you implement / how did you fix it

  1. Create an adapter httpClient to prevent big changes on the client codes

How to test

  1. npm run test

irwansyahwii avatar Jul 19 '24 07:07 irwansyahwii

Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running

npm run test

One of the failed test is src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by using

mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts

I think the failed tests are blocking the github checks.

ok will do

irwansyahwii avatar Aug 08 '24 05:08 irwansyahwii

Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running

npm run test

One of the failed test is src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by using

mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts

I think the failed tests are blocking the github checks.

ok will do

Fixed

irwansyahwii avatar Aug 08 '24 07:08 irwansyahwii

The automated tests are not reliable. Sometimes it failed sometimes it succeed. Seems like there will be big architectural changes to fix it.

irwansyahwii avatar Aug 12 '24 11:08 irwansyahwii

Thank you for your contribution. I will close this pull request since there are no updates and the issue has been resolved. Feel free to re-open if needed.

haricnugraha avatar Mar 14 '25 06:03 haricnugraha