Remove axios package
Monika Pull Request (PR)
What feature/issue does this PR add
- Remove Axios and replace it with native
fetch
How did you implement / how did you fix it
- Create an adapter
httpClientto prevent big changes on the client codes
How to test
npm run test
Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running
npm run testOne of the failed test is
src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by usingmocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.tsI think the failed tests are blocking the github checks.
ok will do
Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running
npm run testOne of the failed test is
src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by usingmocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.tsI think the failed tests are blocking the github checks.
ok will do
Fixed
The automated tests are not reliable. Sometimes it failed sometimes it succeed. Seems like there will be big architectural changes to fix it.
Thank you for your contribution. I will close this pull request since there are no updates and the issue has been resolved. Feel free to re-open if needed.