tonic icon indicating copy to clipboard operation
tonic copied to clipboard

Unmatched license allowance in cargo-deny (gh-actions)

Open simonsan opened this issue 4 years ago • 3 comments

 warning[L006]: license was not encountered
   ┌─ /github/workspace/deny.toml:32:5
   │
32 │     "BSD-2-Clause",
   │     ^^^^^^^^^^^^^^ unmatched license allowance

warning[L006]: license was not encountered
   ┌─ /github/workspace/deny.toml:33:5
   │
33 │     "BSD-3-Clause",
   │     ^^^^^^^^^^^^^^ unmatched license allowance

warning[L006]: license was not encountered
   ┌─ /github/workspace/deny.toml:37:5
   │
37 │     "Zlib",
   │     ^^^^^^ unmatched license allowance

~~Should these be added to the deny.toml?~~

What to do, to make the check pass, so there isn't always a failed CI action?

simonsan avatar Jan 09 '21 19:01 simonsan

I believe this warning is suggesting that these licenses be removed from deny.toml.

olix0r avatar Jan 10 '21 20:01 olix0r

I believe this warning is suggesting that these licenses be removed from deny.toml.

True, I misread that actually. Hmm, anyway, the return value of this CI action defeats a bit the purpose of the CI if there is always one check that is not passing. People will just get used to "ah, this check never passes", not sure if it should be like that. :-/

simonsan avatar Jan 11 '21 07:01 simonsan

Yeah, I've disabled the workflow for now, will have to fix this later on. Its not blocking things at the moment.

LucioFranco avatar Jan 14 '21 21:01 LucioFranco