tonic icon indicating copy to clipboard operation
tonic copied to clipboard

feat: Move Request server util method to RequestExt

Open tottoto opened this issue 1 year ago • 1 comments

Motivation

These utility functionalities seem to be more practical APIs than the other basic ones. Moving them to an extension trait can keep the request implementation more basic. The drawback is that users need to import the trait to use these functionalities.

Solution

Adds an extension trait for request and moves these functionalities to the trait.

tottoto avatar Jul 06 '24 08:07 tottoto

This doesn't seem like an improvement to me.

djc avatar Jul 06 '24 14:07 djc

I don't think we want to take this path right now, I think this adds too much complexity for the added benefit. So for now and the interest of the direction of where the project is going I am going to close this. Once, we start merging in the new foundational code we can reconsider this in the larger group setting.

LucioFranco avatar Jan 23 '25 15:01 LucioFranco