tonic icon indicating copy to clipboard operation
tonic copied to clipboard

Draft: Update to hyper 1.0 and axum 0.7

Open allan2 opened this issue 1 year ago • 4 comments

Hi, apologies for the delay.

This PR is to update hyper to 1.0, http to 1.0, http-body to 1.0, and axum to 0.7.

  • [x] update imports to use -util crates
  • [x] update AddrStream and AddrIncoming
  • [ ] use axum Request and Response in transport (in-progress)
  • [ ] add poll_frame to impl http_body::Body (in-progress)
  • [ ] remove poll_trailers from impl http_body::Body (in-progress)
  • [ ] fix hyper-timeout connector
  • [ ] fix connect, Connect (no more hyper::client::service::Connect)
  • [ ] update version, docs
  • [ ] update examples
  • [ ] many more (tonic-web, etc. Some of these will be in separate PRs)

Depends on:

  • [x] https://github.com/hyperium/hyper/issues/3461

Under consideration:

  • rename tonic::body::BoxBody to tonic::body::Body to match axum
  • now that TcpIncoming has TcpListener as the inner type instead of the deprecated AddrIncoming, can TcpIncoming be simplified?

I tried to break it up so that it is easier to review commit-by-commit. There are some things I am still working through. Any feedback would be helpful.

Closes #1579

allan2 avatar Dec 07 '23 05:12 allan2

@allan2 hello. Do you work on the PR? Maybe do you need help?

ikrivosheev avatar Dec 25 '23 15:12 ikrivosheev

@ikrivosheev I haven't yet. Feel free to contribute :)

allan2 avatar Dec 25 '23 21:12 allan2

@allan2 Is https://github.com/hyperium/hyper-util/pull/78 blocked until https://github.com/hyperium/hyper/commit/a9fa893f18c6409abae2e1dcbba0f4487df54d4f is released? If so, can you conceive of a method utilizing the Config struct in hyper without hyper-body-util for tonic, or will that not be possible? Asking in this PR, because I'd love to patch tonic asap

dsgallups avatar Dec 29 '23 17:12 dsgallups

I opened PR: https://github.com/hyperium/tonic/pull/1595. I will continue working on it.

ikrivosheev avatar Jan 10 '24 16:01 ikrivosheev

This was superseded by #1670, which is now merged.

jplatte avatar Jun 17 '24 14:06 jplatte