hyperium
Add HTTP1 server config for allowing multiple spaces in parsing
Is your feature request related to a problem? Please describe.
We have a situation that we want to allow request to have multi spaces as a request line delimiter.
However, I found that the parser config for server is not exposed to the server builder unlike client.
Because of this, there is no way to use Hyper server to support those use case even though httparse crate has a flag for that feature.
Describe the solution you'd like
Expose the parser config in the similar way as Hyper Client.
As it will be configurable in the builder, it will not break other existing server behavior.
Client side example code: https://code.amazon.com/packages/S3DataEngineHyper/blobs/62a7a6badaba2858361fdc633727a97aed4c8853/--/src/client/conn/http1.rs#L350
Describe alternatives you've considered
- Update the httparse crate default configuration, but this will break the backward compatibility
- Expose ParserConfig itself to the Builder. However, this will make Hyper user to have coupling with httparse config
Additional context Add any other context or screenshots about the feature request here.
Assuming you mean add configuration methods to the server http1::Builder for those options, definitely!
Sorry for late. I double checked and found the ask was to expose this feature for the server.
https://github.com/hyperium/hyper/blob/1c70fab64e90f90025eab364beda927044e356fc/src/proto/h1/role.rs#L165
The change was about enhancing h1_parser_config, and found it is not actually used by Server implementation. It is used by Client only.
Please correct me if I'm wrong.
I believe we need to reopen the ticket again unless I missed the implementation for Server.
We can do like using match ctx.h1_parser_config.parse_request~~() with the default config used currently
I was occupied with others, but now I have some time. Let me create a PR for this.
Ah, I see. So the builder method was added to the public API, but the parser doesn't yet use that config.