hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Documentation link in hyper::client::conn for "Higher-level Client API" should probably go to hyper-util now

Open taladar opened this issue 1 year ago • 1 comments

Version 1.0.1

https://docs.rs/hyper/1.0.1/hyper/client/conn/index.html

The link just goes to the module hyper::client above which only contains conn now. Presumably it refers to the code now moved to hyper-util.

taladar avatar Dec 01 '23 11:12 taladar

After looking out what happend to hyper::Client after stumbling over it in some examples (for sharing a pooled connection in axum), I ended up here. (New to rust, so sorry if I break some conventions or seem rude😅 )

My adventure through this issue, thanks for that :) But the resulting question kind of plays into this:

  • hyper-util, as a new target for the link, already labels the Client as legacy, should anyone be encouraged to use legacy for new code?
  • reqwest (the link provided in the commit 5236ac5) here, depends on hyper 0.14, using hyper::Client internally, as far as I can tell, implying the recommendation of hyper to get a pooled connection is to use an older version of hyper.

As I am new to this, I might misunderstand some things around this :) I'll just leave it as food for thought though (and because I secretly hope I'll end up with a recommendation for a higher level client api)

ketzu avatar Jan 02 '24 21:01 ketzu