hyper-util icon indicating copy to clipboard operation
hyper-util copied to clipboard

Published 20 hours ago • verified publisher icon hyperium

Decompose hyper::Client into utils (part 1)

Open tomkarw opened this issue 2 years ago • 5 comments

Closes https://github.com/hyperium/hyper/issues/3080

tomkarw avatar Aug 07 '23 18:08 tomkarw

This looks pretty good to me! Is it still WIP?

seanmonstar avatar Aug 30 '23 18:08 seanmonstar

@tomkarw any updates? Or can i open new PR?

ikrivosheev avatar Jan 16 '24 07:01 ikrivosheev

As far as I'm concerned this was ready, I was waiting for a review from @seanmonstar, but assumed he's busy with hyper v1 release.

I'll brush it up and hope to merge it in. I don't think making a new PR makes sense.

tomkarw avatar Jan 18 '24 21:01 tomkarw

As far as I'm concerned this was ready, I was waiting for a review from @seanmonstar, but assumed he's busy with hyper v1 release.

I'll brush it up and hope to merge it in. I don't think making a new PR makes sense.

Thank you) this branch had conflicts and if you didn't respond I would open new PR. Sorry, if I confused you.

ikrivosheev avatar Jan 19 '24 05:01 ikrivosheev

This is blocked on decision regarding Http1RequestTarget and is_proxied. I'd love to get someone's opinion on that: https://github.com/hyperium/hyper/issues/3080#issuecomment-1912843548.

tomkarw avatar Jan 26 '24 23:01 tomkarw