http icon indicating copy to clipboard operation
http copied to clipboard

WIP: Allow get user info from authority

Open xoac opened this issue 4 years ago • 5 comments

This PR provides ability to get username and password (userinfo) from Authority.

I proposed 3 ways:

  1. two functions username() and password()
  2. return new struct UserInfo<'a>
  3. return tuple with 2 optional elements username and password.

Personally I would vote for 3 (Of course renamed to user_info).

TODO:

  • [ ] Chose method that should be implemented. user_info user_info2 or pair username and password and remove others.
  • [ ] Add tests to choose method(s)
  • [ ] Add notation to doc about strongly discourage any use with reason that couldn't find in #12

xoac avatar Mar 04 '20 22:03 xoac

Any update?

hronro avatar Jan 05 '23 06:01 hronro

Please merge this PR. It's useful in many situations.

ssrlive avatar Feb 03 '24 10:02 ssrlive

I proposed 3 different API, if crate maintainers are interested and decide witch one is best I am happy to implement it.

I think @seanmonstar is the main maintainer. If you think this is PR is not useful please close with a reason. Thanks.

xoac avatar Feb 03 '24 10:02 xoac

In order to reduce communication delays, could you please resolve the conflict first? @xoac

ssrlive avatar Feb 03 '24 11:02 ssrlive

I will wait for feedback from maintainers to do any work around this

xoac avatar Feb 03 '24 11:02 xoac