http icon indicating copy to clipboard operation
http copied to clipboard

Published 20 hours ago • verified publisher icon hyperium

Have StatusCode::as_str return static reference

Open upsuper opened this issue 5 years ago • 6 comments

upsuper avatar Jan 03 '20 10:01 upsuper

@dekellum Hey! I saw that #381 is closed (not sure what happened there). What about this PR now? Should I rebase or?

upsuper avatar Jan 25 '20 13:01 upsuper

CI was restored in a different way (#387), so you might try to merge with master to get this PR passing.

dekellum avatar Jan 25 '20 19:01 dekellum

Thanks!

upsuper avatar Jan 25 '20 22:01 upsuper

So... the CI is still broken.

I'd suggest you mark nightly with allow_failures, especially given that you have deny(warnings) which is very easy to be broken.

upsuper avatar Jan 27 '20 01:01 upsuper

@dekellum could you have another look? it seems that I can't re-request review, and I have no idea why.

upsuper avatar Jan 29 '20 12:01 upsuper

Your rebased change continues to look good to me!

But I have no commit rights here, nor do I endorse, much less understand, its "governance". All resent commits are by @seanmonstar and @carllerche was previously active. You might try requesting a review from them?

dekellum avatar Jan 29 '20 18:01 dekellum