h2 icon indicating copy to clipboard operation
h2 copied to clipboard

Bad feedback on reset stream

Open Icelk opened this issue 3 years ago • 3 comments

When a stream is reset before calling send_response, the error returned is a Error::User.

That variant doesn't contain any data telling what caused the issue. I propose adding some form of feedback to at least the debug implementation.

This is the file where the error is returned, without any context.

Icelk avatar Jan 03 '22 19:01 Icelk

That sounds like a good improvement to me!

seanmonstar avatar Jan 03 '22 19:01 seanmonstar

This seems like quite a large change, since we'd have to change the (Error)Kind::User variant.

What data should we attach? Another enum containing the context of the user error?

I'd gladly open a PR.

Icelk avatar Jan 04 '22 10:01 Icelk

@seanmonstar Any feedback? :)

Icelk avatar Apr 20 '22 18:04 Icelk