h2 icon indicating copy to clipboard operation
h2 copied to clipboard

Requests should not be provided to user if stream has been reset

Open carllerche opened this issue 7 years ago • 3 comments

For example, the server receives a request, then an invalid sequence of window updates. The stream is then reset. In this case, the server app should never see the request.

carllerche avatar Aug 24 '17 03:08 carllerche

Should this actually be done at this level? You could imagine a request with useful info sent, but the client doesn't want the response at all, and so sends a cancel after the headers. In this case, the app never knows what data was sent.

Even if the stream was reset for another reason, the app may still want to be able to log that.

seanmonstar avatar Nov 15 '17 22:11 seanmonstar

Maybe... it seems OK to punt this question until later. It is not a breaking change either way I would say.

carllerche avatar Nov 29 '17 05:11 carllerche

This issue is kinda at odds with #536. I feel like the user of the h2 crate should see as much as possible of the data that was send to it, as long as it isn't at odds with respecting the semantics of the protocol.

Should we close this?

nox avatar May 06 '21 11:05 nox