hyperfiddle-2020 icon indicating copy to clipboard operation
hyperfiddle-2020 copied to clipboard

hfhf link table default value reaction

Open dustingetz opened this issue 6 years ago • 9 comments

This has just been edited (removed :link/class :hf/new) and now there is a stale link/txfn which came from a previous default value

image

image

dustingetz avatar Mar 01 '19 16:03 dustingetz

The actual :input receives no :value prop which appears to cause this issue image

dustingetz avatar Mar 01 '19 16:03 dustingetz

Related:

  • [ ] Reaction: editing stage doesn’t react cell - same bug. Editing :link/txfn from staging area is intermittent issues which are a fn of default value state.

dustingetz avatar Mar 01 '19 16:03 dustingetz

image

image

dustingetz avatar Mar 27 '19 12:03 dustingetz

I expected this to be value, not defaultValue

image

dustingetz avatar Mar 27 '19 12:03 dustingetz

Reagent is mucking with input value vs defaultValue: image

dustingetz avatar Mar 27 '19 13:03 dustingetz

This can be reliably reproduced here on link/path http://domains.hyperfiddle.net/:domains/

Current theory it only happens on the first edit after a hard refresh

dustingetz avatar Mar 27 '19 15:03 dustingetz

This is after page settles, clear logs, then delete the keyword: image

dustingetz avatar Mar 27 '19 16:03 dustingetz

Root cause was unstable fiddle-src-remderer in ide/edit

dustingetz avatar Mar 27 '19 19:03 dustingetz

Karl says, after investigation, we are using :default-value wrong. We need to be a controlled field at all times, which means implement default value logic ourselves, which impacts the datom generation and the flow of data through debounced, validator, etc.

Confirmed duplicate https://github.com/hyperfiddle/hyperfiddle/issues/894

dustingetz avatar Mar 28 '19 18:03 dustingetz