hyperdx icon indicating copy to clipboard operation
hyperdx copied to clipboard

fix: delimited column identifier for dynamic fields

Open tombokombo opened this issue 4 months ago • 6 comments

Hi, in dynamic fields there could be identifier like log.ctxt.request.Symfony\Component\HttpFoundation\Request (real world example from php logs). Search query will be toString(log.ctxt.request.Symfony\Component\HttpFoundation\Request)= and backend will return 400 Bad request complaining about syntax error. Escaping identifiers with ?? which is shorthand to SqlString.escapeId() solves that problem.

I've removed value length conditions as well. They are no more needed as was mentioned in my previous PR https://github.com/hyperdxio/hyperdx/pull/1064 Fixed another issue with single quotes which was introduced by https://github.com/hyperdxio/hyperdx/pull/1064

tombokombo avatar Aug 31 '25 19:08 tombokombo

🦋 Changeset detected

Latest commit: b57fc16e1d73169050274423aa75cb65ea83b515

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 31 '25 19:08 changeset-bot[bot]

@tombokombo is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 31 '25 19:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Sep 17, 2025 7:25am

vercel[bot] avatar Sep 17 '25 07:09 vercel[bot]

Hi @wrn14897 , could you please take a look?

tombokombo avatar Sep 19 '25 09:09 tombokombo

Hello, I'm running custom build with this patch in production for weeks, could somebody please take a look. Thanks.

tombokombo avatar Oct 02 '25 22:10 tombokombo

Hello, I'm running custom build with this patch in production for weeks, could somebody please take a look. Thanks.

Hey @tombokombo, I will take a look at this PR this week. Thanks!

wrn14897 avatar Oct 03 '25 17:10 wrn14897