hyperdrive icon indicating copy to clipboard operation
hyperdrive copied to clipboard

archive.key does not get set if you pass in content

Open joehand opened this issue 6 years ago • 1 comments

If you pass in content as an option, the archive.key never gets set. May also be fixed with #149.

I can PR test for this. Seems like it'd be an easy fix moving the self.key above cb in line linked, but not sure if there is another constraint I'm missing.

joehand avatar Jul 26 '17 00:07 joehand

No it's prob that easy :) Go for it

On Tue, Jul 25, 2017, 17:44 Joe Hand [email protected] wrote:

If you pass in content as an option, the archive.key never gets set https://github.com/mafintosh/hyperdrive/blob/master/index.js#L696. May also be fixed with #149 https://github.com/mafintosh/hyperdrive/issues/149.

I can PR test for this. Seems like it'd be an easy fix moving the self.key above cb in line linked, but not sure if there is another constraint I'm missing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mafintosh/hyperdrive/issues/175, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW_VU2VNKMDET-cTv9m4RLSDjJfdfMyks5sRovVgaJpZM4OjSw4 .

mafintosh avatar Jul 26 '17 03:07 mafintosh