cli
cli copied to clipboard
hypercore-protocol
Allow spawned daemon processes to remain running
I'm slightly perplexed as to how this used to work, but testing either way shows that the daemon processes spawned by hyp daemon start have a tendency to terminate if they are launched without disconnecting their stdio from the parent process.
This fix works and without it the CLI-tool doesn't work. A new release with this included would be nice.
What's the easiest way to test this locally? 🤔
Pull this fork to test the fix locally: https://github.com/specious/cli/tree/fix/daemon-start
What's the easiest way to test this locally? 🤔
I pull PR's into a branch to test them like this:
git fetch origin pull/57/head:pr-57
git checkout pr-57
@pfrazee, no doubt you are busy, but all you need to do is merge and push to npm.
@specious hi! we've been focused on making the latest hypercore and hyperdrive (see the -next repos). i suggest you take a look at those. we'll be deprecating the deamon when those land, as they allow for much easier "embedded" workflows so you don't need a daemon at all which is nice.
suggest you join the discord if you wanna know more :)
That's quite exciting, but merging this pull request would fix the version that people are currently trying to use.
@mafintosh Can we get this merged and published as a patch? I'm installing this globally with npm i @hyperspace/cli -g and manually editing this file to make it work. I realize you are working on more important things that will be coming out, but there are people relying on this to make it work on node 16.
@ralphtheninja Same. I came across this project today and I wanted to give it a try. NodeJS LTS installed, everything fine... but what... it does not work! Would really appreciate if this was merged.
For the time being, we can install it directly from this pull request:
npm i -g hypercore-protocol/cli#pull/57/head
For the time being, we can install it directly from this pull request:
I had no clue you could do this. Very nice!