IFC-gen
IFC-gen copied to clipboard
Published
20 hours ago •
hypar-io
hypar-io
Don't do null checks on non-nullable types.
Current exceptions during compile:
IFC.g.cs(8914,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcKnotType' is never equal to 'null' of type 'IfcKnotType?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(8872,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcBSplineCurveForm' is never equal to 'null' of type 'IfcBSplineCurveForm?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(9075,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcKnotType' is never equal to 'null' of type 'IfcKnotType?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(9026,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcBSplineSurfaceForm' is never equal to 'null' of type 'IfcBSplineSurfaceForm?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(9674,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcBooleanOperator' is never equal to 'null' of type 'IfcBooleanOperator?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(10126,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcTrimmingPreference' is never equal to 'null' of type 'IfcTrimmingPreference?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(14840,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcTransitionCode' is never equal to 'null' of type 'IfcTransitionCode?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(27138,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcTextPath' is never equal to 'null' of type 'IfcTextPath?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(29702,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcSIPrefix' is never equal to 'null' of type 'IfcSIPrefix?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(29703,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcSIUnitName' is never equal to 'null' of type 'IfcSIUnitName?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
IFC.g.cs(32182,19): warning CS0472: The result of the expression is always 'true' since a value of type 'IfcSurfaceSide' is never equal to 'null' of type 'IfcSurfaceSide?' [/Users/ikeough/Documents/IFC-gen/lang/csharp/src/IFC-dotnet.csproj]
These exceptions are because in GetStepParameters() we are doing null checks on non-nullable types. We should redesign how this gathering of STEP parameters works so as not to do a null check on non-nullable types.
