svcs
svcs copied to clipboard
Make get_pings include locally defined services
Summary
This pull request makes it possible to retrieve the pings from locally defined services, as discussed in https://github.com/hynek/svcs/discussions/81 and referenced to in https://github.com/hynek/svcs/issues/82.
Pull Request Check List
- [x] Typos aside (please, always submit typo fixes!), I understand that this pull request may be closed in case there was no previous discussion.
- [x] Do not open pull requests from your
main
branch – use a separate branch!- There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
- This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
- [x] Added tests for changed code.
- The CI fails with less than 100% coverage.
- [x] New APIs are added to our typing tests at https://github.com/hynek/svcs/blob/main/tests/typing/.
- [ ] Updated documentation for changed code.
- [ ] New functions/classes have to be added to
docs/core-concepts.md
or one of the integration guides by hand. - [ ] Changed/added classes/methods/functions have appropriate
versionadded
,versionchanged
, ordeprecated
directives.- The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
- [ ] New functions/classes have to be added to
- [x] Documentation in
.rst
and.md
files is written using semantic newlines. - [x] Changes (and possible deprecations) are documented in the changelog.
- [x] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.