structlog icon indicating copy to clipboard operation
structlog copied to clipboard

WIP: Handle Logger.exception() outside "except" block

Open sscherfke opened this issue 1 year ago • 1 comments

Fixes: #634

Summary

Pull Request Check List

  • [ ] Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
  • [ ] Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • [ ] New APIs are added to our typing tests in api.py.
  • [ ] Updated documentation for changed code.
    • [ ] New functions/classes have to be added to docs/api.rst by hand.
    • [ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
  • [ ] Documentation in .rst and .md files is written using semantic newlines.
  • [ ] Changes (and possible deprecations) are documented in the changelog.
  • [ ] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

sscherfke avatar Jul 24 '24 08:07 sscherfke

I think that 0c02f29fa259c3173ed0c0b6247a093f41ac312f really fixes the problem in the right way. I added a longer description to the commit to explain why.

Let me know, what you think :)

sscherfke avatar Jul 26 '24 21:07 sscherfke

close on the wish of the author due to lack of feedback from OP

hynek avatar Nov 09 '24 06:11 hynek

@hynek could you please re-open this MR? I think we misunderstood each other. The issue is still relevant and the MR went in the right direction.

I will finish it so that it can be mergd.

sscherfke avatar Nov 27 '24 20:11 sscherfke

CleanShot 2024-11-28 at 06 48 19@2x

looks like I can't reopen it – you'll have to recreate a new one. never seen this before

hynek avatar Nov 28 '24 05:11 hynek