hygieia-core icon indicating copy to clipboard operation
hygieia-core copied to clipboard

#293 Restore the behavior of adding COMMIT and BUILD stages to pipeline

Open VivekBuzruk opened this issue 4 years ago • 5 comments

Affects: <hygieia-core-version-number>.


Overwrite with earlier commit + make few changes for Commit.

Pipeline is at the junction of Team and Product, so one need not iterate across ProductCIs, but navigate appropriately through aligned TeamDashboards while associating Stages with Pipeline.

VivekBuzruk avatar Jan 10 '21 17:01 VivekBuzruk

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vivek Buzruk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 10 '21 17:01 CLAassistant

@VivekBuzruk please sign the CLA and we will accept the change

rvema avatar Jan 11 '21 16:01 rvema

CLA Signed, but still showing pending

image

VivekBuzruk avatar Jan 12 '21 01:01 VivekBuzruk

Hi, the previous PR was to fix an NPE, reverting the changes may bring back the NPE which we want to avoid. You mentioned you added a few additional changes for Commit, but I'm not seeing those. Can you verify?

chzhanpeng avatar Jan 12 '21 15:01 chzhanpeng

NPE (Null Pointer Exception) in Unit Test?? I also modified CommitEventListenerTest which now maps to find a collectorItem.

Btw. prior to #192, CommitEventListener has a loop "for (CollectorItem SCM : SCMs) ". I do not think this is required (rather it may result wrong mapping if there are multiple SCMs).

VivekBuzruk avatar Jan 13 '21 02:01 VivekBuzruk