UI icon indicating copy to clipboard operation
UI copied to clipboard

UI with Angular 11

Open VivekBuzruk opened this issue 3 years ago • 5 comments

While working on Product Dashboard, I moved this project to Angular 11.

If it does not hamper existing work, I can generate pull request in next 2-3 weeks. Will it make sense?

Btw. Product Dashboard is still not complete and is a work in progress (but progress is good).

VivekBuzruk avatar May 18 '21 02:05 VivekBuzruk

Hi!

Just checking again --> whether it is ok to raise PR with new changes (where I moved the code to Angular 11)?

I feel, project owner should create master_11 branch to which my PR can be merged.

Let me know. As I see today, if everything is ok, I should be able generate PR by max. early next week.

regards

VivekBuzruk avatar Jun 01 '21 13:06 VivekBuzruk

@VivekBuzruk Please create PR and share.

nameisaravind avatar Jun 01 '21 16:06 nameisaravind

Hey Vivek!

I am picking up the story to upgrade our angular version from v8-v11 so I'll be supporting and be your POC to get your PR merged and tested :) Please go ahead and open the PR

Sandhya-Rajasabeson avatar Jun 01 '21 16:06 Sandhya-Rajasabeson

Hey @VivekBuzruk, we are in progress of restructuring our repositories. Once this effort is done shortly, I will reach out about opening a PR to the restructured Hygieia UI repo. Thank you for your patience.

Sandhya-Rajasabeson avatar Jun 02 '21 16:06 Sandhya-Rajasabeson

Hi @Sandhya-Rajasabeson ,

Apart from moving to Angular 11, I have done good amount of changes to UI in general and planning to make more. I made few changes to widgets and started building a foundation for Product Dashboard.

Not sure whether your restructuring plans will result in confusion for me and / or duplication. Instead, appreciate if you can accept my PR and then work on restructuring (esp.ly UI). Will submit PR by max. early next week.

VivekBuzruk avatar Jun 03 '21 00:06 VivekBuzruk