Yunfei He

Results 129 issues of Yunfei He

Just for recording. It will be helpful once we want to polish current watch mode implementation in the future. Refs: - https://github.com/rolldown/rolldown/issues/6393 ## Close mechanism in watch mode https://github.com/rolldown/rolldown/blob/0dd43df3e6361db141b41b118ddde191997400cb/crates/rolldown/src/watch/watcher_task.rs#L59 is...

tracking

Nicely done. I still feel there're some bad code smells here. Let me illustrate in a separate issue without blocking this PR. _Originally posted by @hyf0 in https://github.com/rolldown/rolldown/pull/6860#pullrequestreview-3446389832_ --- Some...

Refs: - https://github.com/webpack/webpack/blob/e0219482aafb9087a50ca0be45110727a33801fb/lib/optimize/SplitChunksPlugin.js#L988-L999

p1: important

Refs: - https://github.com/webpack/webpack/blob/e0219482aafb9087a50ca0be45110727a33801fb/lib/util/deterministicGrouping.js#L32-L41

p1: important

- Thought of this while developing https://github.com/rolldown/rolldown/pull/7179. - Should at least come up with some rules for emitting readable/friendly logging instead of using it like a `println` or `dbg!` just...

I still want to check esbuild's behavior in relation to this. _Originally posted by @hyf0 in https://github.com/rolldown/rolldown/issues/6786#issuecomment-3472124695_ --- Refs: - https://github.com/vitejs/rolldown-vite/issues/459#issuecomment-3441031606

p2: significant / minor bug

- [ ] Support equivalent of webpack's [`SplitChunks#chunks`](https://webpack.js.org/plugins/split-chunks-plugin/#splitchunkschunks) - [ ] `maxSize` should be renamed with a more semantic name which infers its' behavior - [ ] Eliminate barrel chunks...

tracking

Not sure why, but it keeps showing up recently https://github.com/rolldown/rolldown/runs/53880575830

Refs: - https://publint.dev/docs/ Some thoughts: - All js packages should be verified by `publint` - This process should part of `CI` - Not sure if `publint` could catch https://github.com/rolldown/rolldown/pull/6926, but...

Had discussed with devtools team. The `debug` keyword would be used for other purpose, like debugging rolldown itself. We want to switched to `devtools` to carry related code for clarity....