Yunfei He

Results 368 comments of Yunfei He

> Can you draft a PR for us Sure. I'll finish it tomorrow. I will add dts bundling support as a builtin plugin. To do it, I need to do...

We have https://github.com/sxzz/rolldown-plugin-dts now. Though it's still different from what this PR proposed. However, we are satified at this point.

* **#2424** * **#2423** 👈 * **#2422** * **#2420** * **#2419** * `main` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hyf0 and the...

Yeah. We noticed this. Fixing this basically move to create dynamic string. I'm fine with it. But the follow up thing is that using `arcstr` crate seems not necessary too.

Let's have some conclutions first instead of let contributors come up with the solution.

I guess it's ok to keep using `arcstr`.

`import.meta.resolve` and `require.resolve` could be supported, but we currently don't have plan for them.

> I don't think `import.meta.resolve` can be transformed to `require.resolve`. `import.meta.resolve` resolves similar to `import` while `require.resolve` resolves similar to `require` (for example, think about a package with `require` condition)....

I don't see there's a better way to do this. Bundler itself isn't aware of multiple configs. We could do a option validation on nodejs side, emit a warning for...

> How about clean the out dirs in the node side before the bundler is called: Won't consider about this direction due to design principle. --- I also see users...