hydrus icon indicating copy to clipboard operation
hydrus copied to clipboard

URL class option 'alphabetize GET parameters' is no longer respected

Open GunnerGuyven opened this issue 1 year ago • 2 comments

Hydrus version

574

Qt major version

Qt 6

Operating system

Linux (specify distro and version in comments)

Install method

Third party (AUR, Docker, Chocolatey, etc. Specify in comments)

Install and OS comments

Arch AUR

Bug description and reproduction

The setting in question is found at: network > downloader components > manage URL classes > edit URL class > options > alphabetize GET parameters when normalizing

This option worked until recently (I am not sure which version the regression happened in). This option appears to be no longer respected, resulting in failures when accessing particularly strict servers.

Option Off: image

Option On (for comparison, behavior is on always): image

Log output

No response

GunnerGuyven avatar May 10 '24 18:05 GunnerGuyven

Did some experimenting and the issue was first present in the 570 release. The parameters aren't alphabetised in 569 with this option toggled off (windows 11. extract only method of installing)

GeorgeEBeresford avatar May 10 '24 22:05 GeorgeEBeresford

Sorry. Just checked and importing with 569 causes it to fail as the additional url is alphabetised (even though under url classes, it shows it as non-alphabetised).

It imports with the correct non-alphabetised field in 568 Test Build 3. Soon as it hits 569 Future Build, it alphabetises the parameters while importing (with the opton unchecked).

Hope that helps narrow the issue down!

GeorgeEBeresford avatar May 10 '24 23:05 GeorgeEBeresford

Thank you for this report. I am sorry for the trouble--when I recently updated the encoded URL handling, my master 'let's wash this URL as soon as it is ingested' method, which converts space to %20 and so on, was by default alphabetising all query parameters. This wasn't caught in URL unit tests because they couldn't see the forest for the trees. I have fixed it and added a new test.

Let me know if you have any more trouble with it in v575.

hydrusnetwork avatar May 14 '24 20:05 hydrusnetwork

I've tested v575 now and the behavior is correct for this feature. Thank you for the great work!

GunnerGuyven avatar May 21 '24 13:05 GunnerGuyven