tiingo-python icon indicating copy to clipboard operation
tiingo-python copied to clipboard

[Enhancement] Add afterHours parameter to IEX intraday requests

Open GenusGeoff opened this issue 5 years ago • 4 comments

  • Tiingo Python version: 0.13
  • Python version: 3.8.5
  • Operating System: Ubuntu 18.04 LTS/Linux

Description

I suggest that we add the afterHours=<TRUE/FALSE> flag for IEX intraday quotes (REST endpoint). I may code this myself as I'm spending a bit more time with this project. But, I wanted to make the official request.

What I Did

N/A

?afterHours=True [or False, defaults to False]

FILES AFFECTED: api.py

GenusGeoff avatar Dec 03 '20 03:12 GenusGeoff

Hi @GenusGeoff , thanks for filing this! I think this would be a welcome addition.

There was a contribution that someone started last year, but didn't end up finishing. I left some notes on the PR It points to the area of code that you might end up modifying, if you'd like to use it as a reference. Let me know if you have any questions about how to make a modification to the library - I have documentation here for how to get a local environment set up.

https://github.com/hydrosquall/tiingo-python/pull/332

hydrosquall avatar Dec 05 '20 19:12 hydrosquall

I will find some time to work on this some more. I appreciate the feedback.

GenusGeoff avatar Jan 03 '21 07:01 GenusGeoff

Please see #527

GenusGeoff avatar Feb 28 '21 00:02 GenusGeoff

Please see Bug Fix #600 before attempting to implement this feature.

GenusGeoff avatar Mar 24 '21 02:03 GenusGeoff