hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Layer Sample Preview in Instrument Editor > Layers does not work as expected

Open theGreatWhiteShark opened this issue 3 years ago • 4 comments

In the layer view within the Instrument Editor when clicking on a line representing a sample I would expect that

  1. the x position of the cursor will control the velocity of the sound (to adjust the extend of the blue bars)
  2. the row/line clicked will trigger the same represented there.

The 1. is not implemented yet but would be desirable. But the 2. does only work if there is no overlap in the layers. Seems like it's implemented by inserting a note with the corresponding velocity the blue bar starts/ends/etc. and pushed to the note queue. So, if there is an overlap and "first in velocity" is chosen as sample selection algorithm, the lower one will be played back exclusively. For "random" a random sample will be played back etc.

theGreatWhiteShark avatar Aug 22 '21 21:08 theGreatWhiteShark

Hum, this might be fixed with one of my pending PR (the one about instant feedback). Hum, actually not, but I rewrote the sound preview here for similar reasons (playing the actual edited sample)

charbeljc avatar Aug 26 '21 17:08 charbeljc

Hum, this might be fixed with one of my pending PR (the one about instant feedback). Hum, actually not, but I rewrote the sound preview here for similar reasons (playing the actual edited sample)

This PR is among the first things I will have a look at as soon as I have more time at hand. :wink:

theGreatWhiteShark avatar Aug 31 '21 12:08 theGreatWhiteShark

Hum, this might be fixed with one of my pending PR (the one about instant feedback). Hum, actually not, but I rewrote the sound preview here for similar reasons (playing the actual edited sample)

This PR is among the first things I will have a look at as soon as I have more time at hand. wink

Hi @theGreatWhiteShark I just did merge development into my PR :relaxed:

charbeljc avatar Sep 05 '21 15:09 charbeljc

Hi @theGreatWhiteShark I just did merge development into my PR relaxed

I think in a couple of weeks (maybe 2 or 3) I'm back and will take a look. Today was the first day in nursery school. There is light at the end of the tunnel :smile:

theGreatWhiteShark avatar Sep 06 '21 09:09 theGreatWhiteShark