Instrument Editor > Layers usage and bugs

[theGreatWhiteShark]

Hydrogen version * : d7d3db9a64bd605bfb40291fe907d5d9aec13b4d

---

There are a few things about the Layers view in the Instrument Editor which do not work or should work more conveniently.

bugs

• [x] renaming of a component (via the drop down menu) does not work
• [x] creating a new component does not check whether it's name does already exist. If there already is one with the same, the component does seem to be created regardlessly but can not be accessed via the GUI
• [x] when opening Hydrogen the layer at the bottom is indicated to be selected but the one at the top is shown in the wave display and affected by the control buttons.~(fixed via #1488 )

tweaks

• [ ] allow renaming the component by double clicking its name
• [ ] move between different layers using the arrow keys
• [ ] pressing Return on an empty row in the layer view should open the 'Load Layer' dialog and pressing it on an existing layer should open 'Edit Layer'
• [ ] pressing Delete should trigger 'Delete Layer'
• [x] ~deleting a component in one instrument will delete it in all other instruments too. At least I did find that quite unexpected. I would suggest we add a warning popup upon deletion if there are more than zero non-empty layers for this component in any instrument.~ (#2021)
• [ ] moving layers via drag & drop
• [ ] Indicate that sample was altered via the SampleEditor by e.g. using a different color or an icon
• [ ] adding, removing, and editing layers/samples can not be undone.

[oddtime]

I agree.

Also: "delete" doesn't work if there exists only one component. That is ok but I would suggest to show "delete" menu item as inactive in this case.

To clear a component I see two ways (first is preferable):

1. implement the selection of multiple layers (shift+click or ctrl+click)
2. add a "clear" menu item