Windows case sensitivity bug in samples

[notsmoothsteve]

Hydrogen version * :1.0.1 Operating system + version : Windows 10 2004 x64 Audio driver + version : N/A

---

Windows filesystems generally preserve case but are not case-sensitive. This seems to cause problems in H2 if trying to use two different samples in the same drum kit if the file names for those sample differ only in case. My suspicion is that this bug only occurs on Windows, as *ix filesystems generally offer full case sensitivity.

I'll give two different ways to reproduce the problem; I believe both are caused by the same bug. For both, we use two sample files - let's say HiHat.flac and Hihat.flac - whose names differ only in case and which sound different enough that you can tell which one it is (e.g. one is from an acoustic drum set and the other is from a drum machine). I initially noticed the problem of method 1 in a drum kit I set up but have since reproduced it by doing method 1 in a brand new, empty drum kit. I then thought of method 2 and tested it in a brand new, empty drum kit.

Method 1: replacing a sample Create an instrument in a drum kit. Load HiHat.flac as its sample. I test it and it plays the sample I loaded. Save the drum kit [note: I'm not sure if saving it is necessary to trigger the bug but now that I think about it, this is part of what I did]. Then I realize I loaded the wrong sample, so I click Delete Layer and then load Hihat.flac to replace it. I test it and it plays the correct sample. Save the drum kit. Exit H2. Load H2, load the drum kit, and test the instrument. It plays the original sample, not the one I replaced it with.

Method 2: two instruments in same drum kit Create two instruments in a drum kit. Load HiHat.flac as the sample for one and Hihat.flac as the sample for the other. I test the two instruments and each plays the correct sample. Save the drum kit. Exit H2. Load H2, load the drum kit, and test the instruments. Both now play the same sample.