hydroflow icon indicating copy to clipboard operation
hydroflow copied to clipboard

ci: fix python hydrocli build

Open MingweiSamuel opened this issue 8 months ago • 4 comments

https://github.com/hydro-project/hydro/actions/workflows/build-cli.yml

linux-cross (aarch64-unknown-linux-gnu, aarch64)

warning: [email protected]: In file included from /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/pregenerated/chacha-armv8-linux64.S:4:0:
warning: [email protected]: /root/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/include/ring-core/asm_base.h:73:2: error: #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:  #error "ARM assembler must define __ARM_ARCH"
warning: [email protected]:   ^
error: failed to run custom build command for `ring v0.17.14`

windows (aarch64-pc-windows-msvc, x64)

warning: [email protected]: clang: error: no such file or directory: '/imsvc\\?\C:\Users\runneradmin\AppData\Local\cargo-xwin\xwin/crt/include'
warning: [email protected]: clang: error: no such file or directory: '/imsvc\\?\C:\Users\runneradmin\AppData\Local\cargo-xwin\xwin/sdk/include/ucrt'
warning: [email protected]: clang: error: no such file or directory: '/imsvc\\?\C:\Users\runneradmin\AppData\Local\cargo-xwin\xwin/sdk/include/um'
warning: [email protected]: clang: error: no such file or directory: '/imsvc\\?\C:\Users\runneradmin\AppData\Local\cargo-xwin\xwin/sdk/include/shared'
error: failed to run custom build command for `ring v0.17.14`

Seems to be an issue with building ring for python, which is a new dependency added yesterday: https://github.com/hydro-project/hydro/commit/6d24901550fa873fc8b4b474f9f6316d98cf7aa8#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR4056-R4068

MingweiSamuel avatar Mar 28 '25 20:03 MingweiSamuel

Is this a sign to just fully deprecate the Hydro Deploy Python interface? The only concrete user is toplotree, which we may be splitting out to a repo with a pinned version anyways...

shadaj avatar Mar 28 '25 20:03 shadaj

Is this a sign to just fully deprecate the Hydro Deploy Python interface

Yeahh

MingweiSamuel avatar Mar 28 '25 21:03 MingweiSamuel

Windows aarch64 builds will be fixed when https://github.com/briansmith/ring/pull/2216 lands

shadaj avatar Mar 29 '25 03:03 shadaj

Linux aarch64 fixed by https://github.com/hydro-project/hydro/pull/1819 , windows disabled in https://github.com/hydro-project/hydro/pull/1820

MingweiSamuel avatar Apr 09 '25 17:04 MingweiSamuel