hydra
hydra copied to clipboard
hydralauncher
Readme modifications
Hello guys, my first PR here, so basically the changes are:
- Add pb-br readme (WIP, there are a lot of parts still in english)
- Change discord link to telegram
- Remove discord tag
- Add readme links to other languages
- Make the list of contributors dynamic using contrib.rocks
Here is how it will be:
Very nice! But it should be exaclty "Вклад", not "Сотрудничество"
Сотрудничество is a common word for partnership which involves money and mutual benefits, while Вклад means selfless help without any profit
Very nice! But it should be exaclty "Вклад", not "Сотрудничество"
Сотрудничество is a common word for partnership which involves money and mutual benefits, while Вклад means selfless help without any profit
Humm, got it, will make the change.
I changed it because here is written "Сотрудничество"
Can i change them both to "Вклад"?
The nice part of using tags is that i can reference then, so can keep all session refs in english regardless of the text heheh
Very nice! But it should be exaclty "Вклад", not "Сотрудничество" Сотрудничество is a common word for partnership which involves money and mutual benefits, while Вклад means selfless help without any profit
Humm, got it, will make the change.
I changed it because here is written "Сотрудничество"
Can i change then both to "Вклад"?
Yup! Exactly! Thanks for your PR!
anyone knows if there is a better way to do this? it will become very poluted if there are a lot of langs
maybe a folder with READMEs? and the default readme can reference the en version on this folder, but be literally only a reference link
humm, only now I have seem that we use https://github.com/akhilmhdh/contributors-readme-action to automate contributors list, but it only changes the README.md., the other localization files stil need manual updates...
Should we remove it from the workflow then? just using contrib.rocks would make it automatic with all files
humm, only now i have seem that we use https://github.com/akhilmhdh/contributors-readme-action to automate contributors list, but it only changes the README.md., the other localization files stil need manual updates...
Should we remove it from the workflow then? just using contrib.rocks would make it automatic with all files
We used to use contrib.rocks, but then replaced with the GH action. But, you have a great point. It would be better to go back to contrib.rocks and have less trouble updating READMEs
Hey @piradata , I made a few comment. Could you update the original README and the others as well? Other than that LGTM
@piradata, ping me back when you are done. Also, do you think you can finish the pt-BR translation? If not, I think I can do it myself later
@zamitto I am done here, will update the translations later with some other things I want to change, initially I wanted to just change the discord link to telegram, but could not keep my ADHD under control hahah
One last change, now that we wont use discord anymore, you can also delete the Discord asset file (src/renderer/assets/discord-logo.svg) @piradata
I think we can just let it there no? we can reuse it later if we change idea or for other things, and if we delete it, makes sense to also delete the text on the localization files