hydra icon indicating copy to clipboard operation
hydra copied to clipboard

Feature change language & Fullscreen options in settings

Open darkjontex opened this issue 9 months ago • 2 comments

Including options in settings to allow:

  • Open Hydra Launcher in Fullscreen mode or custom resolution.
  • Change the Language system for a custom one.

Everything is saved as userPreferences, so if you clear your Hydra Launcher Cache, everything is reset.

I hope you guys can implement or use part of the code. Once again, thanks for the project Hydra Launcher.

darkjontex avatar May 09 '24 12:05 darkjontex

Someone from Los Broxas can review my PR? I would like to contribute with those features for Hydra Launcher.

darkjontex avatar May 10 '24 16:05 darkjontex

  • Fixed points about Style and Select component for Language.
  • Removed Input Fields for Resolution.

image

image

darkjontex avatar May 10 '24 19:05 darkjontex

Ok, i took a better look into your PR. There are some problems:

  1. A lot of comments
  2. Your PR aims to do 2 things (persist screen resolution and change language)
  3. None of these things seems done
  4. Your options inside the Select are hard coded. If you want to work on this feature, you need to figure out a way to dinamically load your options so we dont have to revisit this component every time a new localization is added

I will have to close this PR, and I suggest you do only one thing per PR.

zamitto avatar May 13 '24 01:05 zamitto

does not seems so hard to make it dynamic, its basically just do the same that the localization plugin does, reading the folders at the localization directory. you can use the same var it uses and convert the local code back to language name

piradata avatar May 13 '24 04:05 piradata

will take a look at the language changer later this week if no one does, seems funny

piradata avatar May 13 '24 04:05 piradata

ok

darkjontex avatar May 13 '24 15:05 darkjontex