hydra icon indicating copy to clipboard operation
hydra copied to clipboard

Feature/accessibility improvements

Open cj-burning opened this issue 1 year ago • 3 comments

this pr adds some accessibility improvements to the application

⚠️ please turn on the audio for the attached videos

added aria labels to improve accessibility in the achievement feature

before

https://github.com/user-attachments/assets/4f52d2a8-b52e-4d29-aabf-2657bf652543

after

https://github.com/user-attachments/assets/a54c5745-9809-4008-988f-a369a49e83cb

removed repetition for screen readers in sidebar

before

https://github.com/user-attachments/assets/4df4c4c4-ef65-45fa-8065-ad2d9e40102d

after

https://github.com/user-attachments/assets/02ccb33c-8427-4c47-8fd8-02a5c5e1cd63

added tooltips and screen reader support for the back, search, and clear buttons

before

https://github.com/user-attachments/assets/302e6014-cdd7-4467-ac39-4f5282d47cea

after

https://github.com/user-attachments/assets/4e8a8354-7bab-4577-a0e2-597e7f843f8e

improved layout keyboard navigation: sidebar can be controlled with arrow keys, and the search bar can be focused with Ctrl + K and blurred with Escape.

after

https://github.com/user-attachments/assets/5faf4fdc-e15a-4335-953e-050d6f44710d

enabled carousel navigation using the Tab key in media previews

before

https://github.com/user-attachments/assets/c0615ae0-9187-4250-88bf-36d0e291e7a5

after

https://github.com/user-attachments/assets/b5093b8a-18fc-4512-9c1a-09ab7afd7f08

added aria labels to improve accessibility in the game details sidebar

before

https://github.com/user-attachments/assets/ed5682fd-c377-4e82-afa4-4020a5b910c1

after

https://github.com/user-attachments/assets/cef86fcb-3be6-4d60-9e56-fdd602a14f2c

cj-burning avatar Oct 24 '24 19:10 cj-burning

@cj-burning could you update the pr after the last update? I fixed the conflicts, but the AchievementList component was moved to its own file

zamitto avatar Dec 28 '24 16:12 zamitto

LGTM. @zamitto any considerations?

Last week I has fixed some conflicts in this PR and some changes were lost because a component had moved to another file. But nothing that we can't add by ourselves Current state of PR is ok to me as well

zamitto avatar Jan 05 '25 13:01 zamitto