gocv icon indicating copy to clipboard operation
gocv copied to clipboard

Update videoio.go

Open buYoung opened this issue 4 years ago • 2 comments

Video Writer Ptr() add This function can tell the nil state of VideoWriter

buYoung avatar Jun 21 '20 02:06 buYoung

Codecov Report

Merging #700 into master will decrease coverage by 0.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   97.97%   97.88%   -0.09%     
==========================================
  Files          19       19              
  Lines        2220     2222       +2     
==========================================
  Hits         2175     2175              
- Misses         38       40       +2     
  Partials        7        7              
Impacted Files Coverage Δ
videoio.go 86.07% <0.00%> (-2.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df73d54...e8f9843. Read the comment docs.

codecov-commenter avatar Jun 21 '20 03:06 codecov-commenter

Hello, @buYoung thanks for making a code contribution to GoCV. A couple of things:

  • I switched the branch for this PR to dev, as mentioned here: https://github.com/hybridgroup/gocv/blob/master/CONTRIBUTING.md#how-to-use-our-github-repository
  • Can you please add a "smoke test" as mentioned here? https://github.com/hybridgroup/gocv/blob/master/CONTRIBUTING.md#how-to-add-a-function-from-opencv-to-gocv

Thank you!

deadprogram avatar Jul 06 '20 06:07 deadprogram