hybridgroup
Filestorage roadmap
Thank you very much for the cleanup here @diegohce
Now we probably just need to figure out the permissions on Windows for file writing. Excellent progress, I will try to take a look sometime today.
Please note I changed the branch for this PR to
dev. 😸
Did I mistake the branch... again! ?
Would "/tmp" be a factible directory?
On Wed, Aug 28, 2024 at 4:44 AM Ron Evans @.***> wrote:
@.**** commented on this pull request.
In persistence_test.go https://github.com/hybridgroup/gocv/pull/1208#discussion_r1734159431:
@@ -0,0 +1,54 @@ +package gocv
+import (
- "testing" +)
+func TestFileStorage(t *testing.T) { +
- fs := NewFileStorageWithParams("testdata/filestorage", FileStorageModeWrite|FileStorageModeFormatJson, "utf-8")
Perhaps writing the file into a temp directory would be better and would pass on Windows?
Untested:
pth := filepath.Join(os.TempDir(), "filestorage.json")fs := NewFileStorageWithParams(pth, FileStorageModeWrite|FileStorageModeFormatJson, "utf-8")
— Reply to this email directly, view it on GitHub https://github.com/hybridgroup/gocv/pull/1208#pullrequestreview-2265427783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJCC6H6F3O7VOTIW6P5R73ZTV5XRAVCNFSM6AAAAABNFF2CQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRVGQZDONZYGM . You are receiving this because you were mentioned.Message ID: @.***>
sorry, I missed your code sample. I will try with that right now
On Wed, Aug 28, 2024 at 5:10 PM Diego Cena @.***> wrote:
Would "/tmp" be a factible directory?
On Wed, Aug 28, 2024 at 4:44 AM Ron Evans @.***> wrote:
@.**** commented on this pull request.
In persistence_test.go https://github.com/hybridgroup/gocv/pull/1208#discussion_r1734159431:
@@ -0,0 +1,54 @@ +package gocv
+import (
- "testing" +)
+func TestFileStorage(t *testing.T) { +
- fs := NewFileStorageWithParams("testdata/filestorage", FileStorageModeWrite|FileStorageModeFormatJson, "utf-8")
Perhaps writing the file into a temp directory would be better and would pass on Windows?
Untested:
pth := filepath.Join(os.TempDir(), "filestorage.json")fs := NewFileStorageWithParams(pth, FileStorageModeWrite|FileStorageModeFormatJson, "utf-8")
— Reply to this email directly, view it on GitHub https://github.com/hybridgroup/gocv/pull/1208#pullrequestreview-2265427783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJCC6H6F3O7VOTIW6P5R73ZTV5XRAVCNFSM6AAAAABNFF2CQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRVGQZDONZYGM . You are receiving this because you were mentioned.Message ID: @.***>
Looking good now @diegohce thank you very much for adding this set of long-needed features! Now squash/merging.